fix(cli): avoid second OIDC roundtrip after auth login completion#561
Open
facundo-herodevs wants to merge 1 commit intomainfrom
Open
fix(cli): avoid second OIDC roundtrip after auth login completion#561facundo-herodevs wants to merge 1 commit intomainfrom
facundo-herodevs wants to merge 1 commit intomainfrom
Conversation
v3nant
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/neverendingsupport/idp/issues/93
What This Branch Does
This branch removes the extra browser auth roundtrip that happened after
hd auth loginhad already completed successfully on the local callback. Instead of sending the browser to the web OAuth callback route, the CLI now finishes on the staticcli-logged-inpage so the user sees a single completion flow.CLI Login Completion
config.eolLogInUrlto usehttps://apps.herodevs.com/eol/cli-logged-ininstead ofhttps://apps.herodevs.com/eol/api/auth/cli-log-in.src/config/constants.ts.Test Coverage
test/commands/auth/login.test.tsto assert that the browser response now returns a302to the static completion page, including the exactLocationheader and response completion checks in the updated success-path assertion.npx vitest run test/commands/auth/login.test.ts.